fix: Make Speaker description width 100% for 992px to 1200px screen #2353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was of width 50% by default ............ according to this issue I made it 100%.
added 40px padding at top so that the author name doesn't stick to the image
houndci-bot
reviewed
Oct 2, 2020
src/backend/_scss/application.scss
Outdated
| @@ -1396,8 +1396,9 @@ a { | |||
| } | |||
|
|
|||
| .speaker-description { | |||
| padding-top:40px; | |||
There was a problem hiding this comment.
Colon after property should be followed by one space
There was a problem hiding this comment.
Colon after property should be followed by one space
@digitalPlayer1125 read this...
There was a problem hiding this comment.
This has been already resolved.
rishi-raj-jain
suggested changes
Oct 2, 2020
rishi-raj-jain
approved these changes
Oct 2, 2020
There was a problem hiding this comment.
Great! @iamareebjamal @mariobehling This seems good to go with!
|
@Raunaksingh100 As you can see that it is just a change in CSS, the travis CI error has nothing to do with it [It is caused due to Selenium Timeout] |
iamareebjamal
changed the title
iamareebjamal
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was of width 50% by default ............ according to this issue I made it 100%.
Checklist
developmentbranch.Short description of what this resolves:
Changes proposed in this pull request:
Fixes #2322