Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Photos Not Reponding #72

Closed
dynamitechetan opened this issue Mar 3, 2017 · 10 comments
Closed

Local Photos Not Reponding #72

dynamitechetan opened this issue Mar 3, 2017 · 10 comments

Comments

@dynamitechetan
Copy link
Member

#60 after this merge the app is trying to load all the photos in my phone and its tuck after the splash screen. I have over 5000 images in my phone.
The log is
I/CACHE: Saved file /storage/emulated/0/WhatsApp/Media/WhatsApp Images/IMG-20160918-WA0012.jpeg (which is now /storage/emulated/0/.PhimpMeCache/040317015410104.png) correctly for each photo.
I think the previous method was good to show only 6 images at once and then load more on button click.
@pa1pal please check.

@CloudyPadmal
Copy link
Contributor

Oh I see! We better integrate a lazy load to it right? Now it's loading the whole gallery!

@dynamitechetan
Copy link
Member Author

I think the previous way is better (6 images at a time and then click to add more) . In this app we have to show images from different sources rg fb, Flickr, WordPress etc. so no need to show a user his full gallery.

@chiragw15
Copy link
Member

How about displaying only one picture from each source i.e fb, wordpress, etc and folder and when a user clicks on it, all pictures of that folder gets displayed. Basically, what a normal gallery app in android phone does.

@CloudyPadmal
Copy link
Contributor

I've implemented a way around huge galleries! So I've added the Add button again.

  • Once the app is open, it will load the first 21 images in the gallery. (21 % 3 = 0) [Any suggestions on how much to load at a time? 🤔 ]
  • Upon clicking on the Add button, it will load the next 21
  • When the gallery is fully loaded, the Add button will be disabled

This way, it will fetch a potion at a time making it efficient against huge galleries!

@chiragw15 From what I observed the app generates different grid views to each source like facebook, google images and there's a ton of gallery support is there :D

I will send the PR soon! 🔍

@dynamitechetan
Copy link
Member Author

please send PR. much needed. I am not able to even start the app.

@abishekvashok
Copy link
Member

abishekvashok commented Mar 4, 2017

@CloudyPadmal a suggestion instead of:

Upon clicking on the Add button, it will load the next 21

Load the images when the user scrolls to the bottom! --- It's a suggestion

@dynamitechetan
Copy link
Member Author

We can have card for all categories and when user click on that we can complete grid with lazy loading

@Abhi2424shek @pa1pal reviews??

@pa1pal
Copy link
Member

pa1pal commented Mar 4, 2017

@dynamitechetan This UI looks very nice.

@abishekvashok
Copy link
Member

@dynamitechetan yes it's very nice 😍 can you implement an additional intent when you press on each card or expand it when you press it. (IMO first one would nice as lazy loading can be done in scroll)

@dynamitechetan
Copy link
Member Author

yes. I was thinking to do the same. Show some photos in the card and then open a new Activity to show all the photos with lazy loading.

CloudyPadmal added a commit to CloudyPadmal/phimpme-android that referenced this issue Mar 5, 2017
Implemented a lazyload mechanism to handle large galleries

fix: Loading same image after trying to edit images

fix: Handled NullPointer on Permission Check Camera Location
pa1pal pushed a commit that referenced this issue Mar 5, 2017
Implemented a lazyload mechanism to handle large galleries

fix: Loading same image after trying to edit images

fix: Handled NullPointer on Permission Check Camera Location
pull bot pushed a commit to sahilsaha7773/phimpme-android that referenced this issue Jul 18, 2019
Implemented a lazyload mechanism to handle large galleries

fix: Loading same image after trying to edit images

fix: Handled NullPointer on Permission Check Camera Location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants