Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete code at DigitalChannel.java #107

Closed
CloudyPadmal opened this issue May 9, 2017 · 2 comments
Closed

Incomplete code at DigitalChannel.java #107

CloudyPadmal opened this issue May 9, 2017 · 2 comments
Assignees

Comments

@CloudyPadmal
Copy link
Collaborator

The method loadData in the DigitalChannel.java file contains an incomplete if else statement at lines 54-60

void loadData(int initialState, double[] timestamps) {
    if (initialStateOverride) {
        // Code not clear
        initialStateOverride = false;
    } else {

    }
@viveksb007
Copy link
Member

Yeah it was not clear at time. Well its still a little ambiguous.
https://github.com/fossasia/pslab-python/blob/development/PSL/digital_channel.py#L41
Have a look at this, initial_state_override was declared a boolean. So whats happening in this line?
If you could decode it. Complete the method a send a PR please.

@CloudyPadmal
Copy link
Collaborator Author

Yes @viveksb007 ! It's a little confusing! In python, anything other than 0 is evaluated true. Not sure what is evaluated in this line of code. I'll give it a try and see 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants