Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polynomial implementation approach revisited #71

Closed
akarshan96 opened this issue Apr 27, 2017 · 2 comments
Closed

Polynomial implementation approach revisited #71

akarshan96 opened this issue Apr 27, 2017 · 2 comments

Comments

@akarshan96
Copy link
Member

akarshan96 commented Apr 27, 2017

Apache Math Common provides a range Polynomial functions that can be used to implement polynomials efficiently. A discussion can take place whether we can use this approach or stick to previous one.

@viveksb007
Copy link
Member

Great we should switch to Apache Common Math. Just take care of one thing about evaluation in numpy.poly1D polynomial is solved as
poly1d([1, 2, 3]) -> x^2 + 2x + 3
and in Apache Common Math, its evaluated as
3X^2+2X+1
So reverse of coefficients should be given when constructing a polynomial instance in Apache common math.

@viveksb007
Copy link
Member

@akarshan96 when can you incorporate Polynomial implementation from apache common math?
#91 Could only be addressed after underlying polynomial implementation is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants