Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lux Meter configurations now saving state #1236

Merged
merged 1 commit into from Jul 17, 2018
Merged

Lux Meter configurations now saving state #1236

merged 1 commit into from Jul 17, 2018

Conversation

harsh-2711
Copy link
Contributor

Fixes #1235

Changes: Used Shared Preferences to save the set values in Configure tab in Lux Meter instrument

Screenshot/s for the changes:
LuxMeterConfig.zip

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:
LuxMeterConfiguration.zip

@CloudyPadmal CloudyPadmal added the Status: Review Required Requested reviews from peers and maintainers label Jul 17, 2018
@CloudyPadmal CloudyPadmal merged commit c795b07 into fossasia:development Jul 17, 2018
@CloudyPadmal CloudyPadmal removed the Status: Review Required Requested reviews from peers and maintainers label Jul 17, 2018
neel1998 pushed a commit to neel1998/pslab-android that referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants