New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved issue of active screen while bottom sheet is up #1355

Merged
merged 1 commit into from Aug 13, 2018

Conversation

3 participants
@harsh-2711
Copy link
Contributor

harsh-2711 commented Aug 11, 2018

Fixes #1329

Changes: Added code to close the bottom sheet when the window behind it is clicked

Screenshot/s for the changes:
20180811_145438

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:
app-debug.zip

@CloudyPadmal
Copy link
Contributor

CloudyPadmal left a comment

These files need to be reformatted to add missing spaces. Also @harsh-2711 can you check if the onclick is working to hide the guide, when the app is freshly installed and without sliding down. It doesn't slide down when I first open it. I suspect the reason to be having onclicklistener set inside the switch as it is not initiated properly.

@harsh-2711

This comment has been minimized.

Copy link
Contributor

harsh-2711 commented Aug 12, 2018

@CloudyPadmal All changes are done. Please review. Also, I haven't reformatted the code rather I have manually added some lines as it would disturb the code of other developers. APK is also updated for testing.

@harsh-2711 harsh-2711 closed this Aug 12, 2018

@harsh-2711 harsh-2711 reopened this Aug 12, 2018

@CloudyPadmal
Copy link
Contributor

CloudyPadmal left a comment

Set the tvShadow.setOnClickListener(new View.OnClickListener() {} in an early state like onCreate. Then we wouldn't need to set it in two places.

Solved the issue of active screen while opening bottom sheet guide
Solved issue while default opening of bottom sheet

Changed the gradle file to default

Removed duplication of code
@harsh-2711

This comment has been minimized.

Copy link
Contributor

harsh-2711 commented Aug 13, 2018

@CloudyPadmal Changes done. Thanks for pointing out duplication.

@abhinavraj23 abhinavraj23 merged commit 1a815c3 into fossasia:development Aug 13, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment