Solved issue of active screen while bottom sheet is up #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavraj23
added
the
Status: Review Required
CloudyPadmal
requested changes
Aug 12, 2018
There was a problem hiding this comment.
These files need to be reformatted to add missing spaces. Also @harsh-2711 can you check if the onclick is working to hide the guide, when the app is freshly installed and without sliding down. It doesn't slide down when I first open it. I suspect the reason to be having onclicklistener set inside the switch as it is not initiated properly.
|
@CloudyPadmal All changes are done. Please review. Also, I haven't reformatted the code rather I have manually added some lines as it would disturb the code of other developers. APK is also updated for testing. |
CloudyPadmal
requested changes
Aug 13, 2018
Solved issue while default opening of bottom sheet Changed the gradle file to default Removed duplication of code
|
@CloudyPadmal Changes done. Thanks for pointing out duplication. |
5 tasks
CloudyPadmal
approved these changes
Aug 13, 2018
abhinavraj23
approved these changes
Aug 13, 2018
CloudyPadmal
removed
the
Status: Review Required
neel1998
pushed a commit
to neel1998/pslab-android
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1329
Changes: Added code to close the bottom sheet when the window behind it is clicked
Screenshot/s for the changes:
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
app-debug.zip