feat: recording functionality in compass instrument #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavraj23
added
the
Status: Review Required
abhinavraj23
suggested changes
Feb 20, 2019
| compassLogger.writeCSVFile("Timestamp,DateTime,Bx,By,Bz"); | ||
| recordData(); | ||
| writeHeaderToFile = !writeHeaderToFile; | ||
| } else{ |
There was a problem hiding this comment.
@Smit2010 Please reformat the code, it shouldn't be this way.
Smit2010
force-pushed
the
development
branch
from
65913b0
to
0d809e4
Compare
CloudyPadmal
requested changes
Feb 24, 2019
| } | ||
|
|
||
| public String getBx() { | ||
| return Bx; |
There was a problem hiding this comment.
Can you append this. to these?
There was a problem hiding this comment.
Are you suggesting to append this. to getters also or only in setters? @CloudyPadmal
| public CompassData() { | ||
| } | ||
|
|
||
| public CompassData(String x, String y, String z) { |
There was a problem hiding this comment.
Use standard practice in object creation. We use the same name and use this key word to refer to the class instance. Change x y z to Bx By and Bz
There was a problem hiding this comment.
Updated. @CloudyPadmal
Smit2010
force-pushed
the
development
branch
3 times, most recently
from
b81a5ea
to
417435d
Compare
CloudyPadmal
approved these changes
Mar 2, 2019
abhinavraj23
approved these changes
Mar 2, 2019
vansha10
pushed a commit
to vansha10/pslab-android
that referenced
this pull request
Mar 24, 2019
CloudyPadmal
removed
the
Status: Review Required
neel1998
pushed a commit
to neel1998/pslab-android
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1371 Recording functionality added in compass instrument
Changes: added function of record data in CompassActivity and created a new class of compassData
Screenshot/s for the changes:
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:app-debug.zip