Fix #1558 status bar bug fixed, status bar doesnt reappear on opening spinners #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudyPadmal
requested changes
Feb 24, 2019
| @@ -396,6 +400,8 @@ public void run() { | |||
| monitorThread.start(); | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Can you please remove these blank lines? Rest looks good
|
@CloudyPadmal kindly review. I have made the changes. |
CloudyPadmal
approved these changes
Mar 2, 2019
CloudyPadmal
requested changes
Mar 2, 2019
|
@CloudyPadmal i resolved the conflict ..kindly review |
|
@CloudyPadmal kindly review and merge. |
cweitat
approved these changes
Mar 6, 2019
CloudyPadmal
approved these changes
Mar 6, 2019
vansha10
pushed a commit
to vansha10/pslab-android
that referenced
this pull request
Mar 24, 2019
… opening spinners (fossasia#1562) * status bar bug fixed * empty lines removed
neel1998
added a commit
to neel1998/pslab-android
that referenced
this pull request
Jul 30, 2019
… opening spinners (fossasia#1562) * status bar bug fixed * empty lines removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1558
Changes: widow full screen flag set in onCreate method
Screenshot/s for the changes:
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
statusbar_bug.zip