Fix #1759 multimeter record bug fixed #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CloudyPadmal it would be great if you can merge this so that i can start working on #1762 |
CloudyPadmal
requested changes
Jun 1, 2019
CloudyPadmal
added
the
Status: Review Required
|
@CloudyPadmal i have changed the stop icon. I think this can be merged now. |
CloudyPadmal
approved these changes
Jun 1, 2019
CloudyPadmal
removed
the
Status: Review Required
neel1998
added a commit
to neel1998/pslab-android
that referenced
this pull request
Jul 30, 2019
* multimeter record bug fixed * stop button icon changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1759
Changes: Bug fixed, pause button replaced with stop button, csv file created on clicking stop button.
Screenshot/s for the changes:
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
multimeter_log.zip
@CloudyPadmal kindly review