Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1772 Import log working fine for robotic arm controller #1774

Merged

Conversation

neel1998
Copy link
Member

@neel1998 neel1998 commented Jun 5, 2019

Fixes #1772

Changes:
User can now load already saved timelines for robotic arm controller

Screenshot/s for the changes:
20190605_225250

20190605_225308

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:

servo_load_timeline.zip

@neel1998
Copy link
Member Author

neel1998 commented Jun 5, 2019

@CloudyPadmal @mariobehling @ho-dor review

@CloudyPadmal CloudyPadmal merged commit 4b49bdd into fossasia:development Jun 6, 2019
neel1998 added a commit to neel1998/pslab-android that referenced this pull request Jul 30, 2019
@neel1998 neel1998 deleted the robotic_arm_load_timeline branch August 27, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add feature to import saved timeline in robotic arm controller
3 participants