Visual message when no data fetched in gyroscope #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CloudyPadmal @neel1998 please check. |
CloudyPadmal
requested changes
Jun 10, 2019
| recordedGyroArray = new ArrayList<>(); | ||
| resetInstrumentData(); | ||
| plotAllRecordedData(); | ||
| }else{ |
| noSensorText.setAllCaps(true); | ||
| gyroLinearLayout.addView(noSensorText); | ||
|
|
||
|
|
| @@ -133,6 +154,8 @@ public void onDestroyView() { | |||
| } | |||
| if (sensorManager != null) { | |||
| sensorManager.unregisterListener(gyroScopeSensorEventListener); | |||
| }else{ | |||
app/src/main/res/values/strings.xml
Outdated
| @@ -831,4 +831,5 @@ | |||
| <string name="setting_thermo_sensor_gain">setting_thermo_sensor_gain</string> | |||
| <string name="default_value_thermo">0</string> | |||
| <string name="thermo_default">°C</string> | |||
| <string name="no_data_recorded_gyro">No data recorded as the sensor is not present in the device. Try with an external sensor.</string> | |||
There was a problem hiding this comment.
move to relevant section where variable related to gyro is
|
@CloudyPadmal done |
CloudyPadmal
approved these changes
Jun 11, 2019
CloudyPadmal
added
the
Status: Review Required
neel1998
approved these changes
Jun 11, 2019
neel1998
pushed a commit
to neel1998/pslab-android
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1723
Changes: Graphs removed and a visual message to user when no data fetched
Screenshot/s for the changes:
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
gyro.zip