Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: action bar added to logic analyzer #1948

Merged
merged 1 commit into from Aug 19, 2019

Conversation

neel1998
Copy link
Member

@neel1998 neel1998 commented Aug 17, 2019

Fixes #1946

Changes: Actionbar added to logical analyzer

Screenshot/s for the changes:

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing: [Compress the app-debug.apk file into a <feature>.rar or <feature>.zip file and upload it here]
la_actionbar.tar.gz

@neel1998 neel1998 added the Fix Solution to an existing issue in app label Aug 17, 2019
@neel1998 neel1998 self-assigned this Aug 17, 2019
@neel1998
Copy link
Member Author

@CloudyPadmal please review

@CloudyPadmal
Copy link
Collaborator

@neel1998 can you post a screenshot with some data read from LA?

@neel1998
Copy link
Member Author

@CloudyPadmal i have updated the screenshot

@CloudyPadmal CloudyPadmal merged commit ba0373b into fossasia:development Aug 19, 2019
@neel1998 neel1998 deleted the la_actionbar branch August 27, 2019 13:57
makoteq pushed a commit to makoteq/pslab-android that referenced this pull request Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Solution to an existing issue in app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add action bar to Logical Analyzer
2 participants