Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2000 Fixed the repeated display of 'Not Connected' Toast messa… #2002

Merged
merged 1 commit into from Nov 12, 2019

Conversation

abhishekbisht1429
Copy link
Contributor

…ge in DustSensor

Fixes #2000

Changes:
Fixed the repeated display of 'Not Connected' Toast message in DustSensor.
Made Changes to onCreateView() and visualizeData() in DustSensorDataFragment

Screenshot/s for the changes:
fix2000

Checklist:

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:
issue2000fix.zip

Copy link
Contributor

@adityastic adityastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍 @neel1998 rtm

@abhishekbisht1429
Copy link
Contributor Author

Thanks! @adityastic

Copy link
Member

@neel1998 neel1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. @reckoner1429 nice work

@neel1998 neel1998 merged commit 33c4c7c into fossasia:development Nov 12, 2019
AkshobhyaP added a commit to AkshobhyaP/pslab-android that referenced this pull request Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Not Connected' toast message repeatedly keeps popping up in Dust Sensor
4 participants