feat: added a guide for Logic Analyzer Instrument using Alert Dialog Box #944
Conversation
| dontShowAgain = (CheckBox) dialogView.findViewById(R.id.toggle_show_again); | ||
| final TextView tv1 = (TextView) dialogView.findViewById(R.id.custom_dialog_text); | ||
| final TextView tv2 = (TextView) dialogView.findViewById(R.id.description_text); | ||
| final ImageView iv = (ImageView) dialogView.findViewById(R.id.custom_dialog_schematic); |
There was a problem hiding this comment.
Good Java practice is to use meaningful variable names instead of these type of naming
| iv.setImageResource(iconID); | ||
| tv2.setText(desc); | ||
|
|
||
| final android.support.v7.app.AlertDialog dialog = builder.create(); |
There was a problem hiding this comment.
You can import these in the class imports section
| @SuppressLint("ResourceType") | ||
| public void howToConnectDialog(String title, String intro, int iconID, String desc) { | ||
| try { | ||
| final android.support.v7.app.AlertDialog.Builder builder = new android.support.v7.app.AlertDialog.Builder(getContext()); |
There was a problem hiding this comment.
You can import these in the class imports section
| View dialogView = inflater.inflate(R.layout.custom_dialog_box, null); | ||
|
|
||
| final SharedPreferences settings = getActivity().getSharedPreferences(PREFS_NAME, 0); | ||
| String skipMessage = settings.getString("skipMessage", "NOT checked"); |
| View dialogView = inflater.inflate(R.layout.custom_dialog_box, null); | ||
|
|
||
| final SharedPreferences settings = getActivity().getSharedPreferences(PREFS_NAME, 0); | ||
| String skipMessage = settings.getString("skipMessage", "NOT checked"); |
There was a problem hiding this comment.
It's trivial to use a boolean in cases like this rather than a string matching.
| SharedPreferences.Editor editor = settings.edit(); | ||
| editor.putString("skipMessage", checkBoxResult); | ||
| editor.apply(); | ||
|
|
There was a problem hiding this comment.
The whole file needs a reformat.
CloudyPadmal
added
the
Status: Review Required
CloudyPadmal
changed the title
|
@CloudyPadmal All requested changes are done. |
|
@CloudyPadmal Changes done. I thought strings would be OK so I kept them. But now I changed them to Boolean value |
| Boolean checkBoxResult = false; | ||
| if (dontShowAgain.isChecked()) | ||
| checkBoxResult = true; | ||
| SharedPreferences settings = getActivity().getSharedPreferences(PREFS_NAME, 0); |
There was a problem hiding this comment.
Why is it this SharedPreference initialized again? You can use the previously initialized variable can't you?
|
@Vikum94 I made the changes and the duplication was due to using final keyword. |
CloudyPadmal
removed
the
Status: Review Required
Fixes #943
Changes: Added documentation including schematic for Logic Analyzer using Alert Dialog Box which won't pop up when Don't show again is checked
Screenshots for the change:
logic_analyzer.zip
APK for testing:
app-debug.zip