Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crashed on clicking picture in edittext(left) (in mainactivity) #34

Closed
amitiwary999 opened this issue Sep 27, 2016 · 4 comments
Closed

Comments

@amitiwary999
Copy link
Member

No description provided.

@amitiwary999 amitiwary999 changed the title On clicking picture in App crashed on clicking picture in edittext(left) (in mainactivity) Sep 27, 2016
@betterclever
Copy link
Contributor

betterclever commented Sep 28, 2016

@amitiwary999 Please post logs of the crash here.

No need. I have reproduced the error. Looking into it.

@betterclever
Copy link
Contributor

@the-dagger @daminisatya @Orbiter The cause of the issue is when ListView was updated with recyclerView in #13 the possibility of sending images was removed. But the point is whether app needs to send images or not, if not that can be removed completely or in future if something like that is needed, we may add the functionality similar to what was present earlier.

@addiittya2006
Copy link
Contributor

@betterclever I don't think we ever had any functionality for sending images.
@daminisatya Susi Server doesn't have support for Images, right?

This Error is basically caused by a Nullable OnClick event fired with No Action.

@betterclever
Copy link
Contributor

@addiittya2006 Actually, I was referring to the image support in the library itself from which the project was forked, it included support for sending images , not sending actually, just displaying images in the views and for its demo, a button with a functionality that if you'll click that, the avatar image of other person is shown as a reply ( for demo purposes ). I was skeptical about leaving that since we may add support for stickers or related (maybe) in future.

daminisatya added a commit that referenced this issue Sep 29, 2016
Fixes #34: Crash on Avatar OnClick
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants