Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallpaper Not changing #446

Closed
krishnarai30 opened this issue Dec 30, 2016 · 10 comments
Closed

Wallpaper Not changing #446

krishnarai30 opened this issue Dec 30, 2016 · 10 comments
Assignees

Comments

@krishnarai30
Copy link
Member

Actual Behavior

Wallpaper isn't changing.
The image to be applied changes its aspect ratio and saves as a new version of the actual image.

Expected Behavior

Wallpaper is changed.

Steps to reproduce it

Refer screenshots.

Screenshots of the issue

whatsapp image 2016-12-30 at 9 54 55 pm 2
whatsapp image 2016-12-30 at 9 54 55 pm 3
whatsapp image 2016-12-30 at 9 54 55 pm 4
whatsapp image 2016-12-30 at 9 54 55 pm 5
whatsapp image 2016-12-30 at 9 54 55 pm 6
whatsapp image 2016-12-30 at 9 54 55 pm 7
whatsapp image 2016-12-30 at 9 54 55 pm 1

Would you like to work on the issue?
Yes, I have started working on the issue. will send a PR after admin approval.

@chiragw15
Copy link
Member

@krishnarai30 I think it is working fine if you complete action using galley but doesn't work for Google photos. Is it?

@HimanshuS01
Copy link
Contributor

Hey @krishnarai30 what's the progress in this issue.? :)

@krishnarai30
Copy link
Member Author

@HimanshuS01 I am working on the issue and testing it on various devices will send PR within this week.

@abishekvashok
Copy link
Member

@krishnarai30 updates?

@krishnarai30
Copy link
Member Author

@Abhi2424shek at ISGW Hackathon this weekend will send the PR soon.

@abishekvashok
Copy link
Member

Sure take your time, i just wanted to ensure you were on it @krishnarai30

@anantprsd5
Copy link
Member

@krishnarai30 Any updates on this?

@krishnarai30
Copy link
Member Author

Sorry for the delays due to prior appointments I haven't been able to dedicate time to this problem.

@abishekvashok
Copy link
Member

@krishnarai30 so if you wish we could flag this if you so that someone else gets it done as far I understand that it is what you r trying to tell with the last message, but who is a programmer who hates to code, we could wait for you so let us know your decision in poor words for we await it :)

@anantprsd5
Copy link
Member

@krishnarai30 Please let us know if you are working on this or else I want to take this issue.

anantprsd5 added a commit to anantprsd5/susi_android that referenced this issue Feb 3, 2017
the-dagger pushed a commit that referenced this issue Feb 5, 2017
Fixes #446 Now photos can be selected using Google photos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants