fix: crash when selecting some categories from skills activity #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| holder.skillRating.rating = stars.averageStar | ||
| holder.skillTotalRatings.text = stars.totalStar.toString() | ||
| } | ||
| } catch (exception: Exception) { |
There was a problem hiding this comment.
Never catch generic exception
There was a problem hiding this comment.
I know, but there are a lot of exceptions happening, so I did that. Well, I will improve that and try to catch each and every exception separately.
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 04466af. Here's the output:
|
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 42df3f4. Here's the output:
|
...a/org/fossasia/susi/ai/skills/groupwiseskills/adapters/recycleradapters/SkillsListAdapter.kt
Outdated
Show resolved
Hide resolved
...a/org/fossasia/susi/ai/skills/groupwiseskills/adapters/recycleradapters/SkillsListAdapter.kt
Outdated
Show resolved
Hide resolved
iamareebjamal
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2115 #1705
Reasons of Crash:
Skills are fetched in form of SkillData which defines most of its attributes as non-nullable. But many skills coming from the server stores those attributes values as null which causes Exceptions when different methods are called on them. These exceptions inclued IllegalArgumentException, NullPointerException, IndexOutOfBoundException, etc. This causes the app to crash.
Changes: I've handled the exceptions to avoid the crash.