Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Hyperlinked words in textview instead of whole textview #2195

Merged
merged 1 commit into from May 10, 2019
Merged

fix: Hyperlinked words in textview instead of whole textview #2195

merged 1 commit into from May 10, 2019

Conversation

atm1504
Copy link
Member

@atm1504 atm1504 commented May 10, 2019

Fixes #1955

Changes:

  • Corrected the present code of hyperlinking words in text view
  • Updated the string format

Screenshots for the change:
ezgif com-video-to-gif

@auto-label auto-label bot added the fix label May 10, 2019
@iamareebjamal iamareebjamal merged commit 67d5b91 into fossasia:development May 10, 2019
batbrain7
batbrain7 reviewed May 10, 2019
View reviewed changes
Copy link
Member

@batbrain7 batbrain7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atm1504 now, I think no custom tab will open up on clicking the hyperlink text?

@atm1504
Copy link
Member Author

atm1504 commented May 10, 2019

@atm1504 now, I think no custom tab will open up on clicking the hyperlink text?

No. It was opening because of the externally present onClickListener.

@iamareebjamal
Copy link
Member

iamareebjamal commented May 10, 2019 •
edited

I think no custom tab will open up on clicking the hyperlink text?

Which is totally fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batbrain7 batbrain7 batbrain7 left review comments

@iamareebjamal iamareebjamal iamareebjamal approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Whole text working as hyperlink
3 participants
@atm1504 @iamareebjamal @batbrain7