Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bump realm-gradle-plugin to 6.1.0 and fix build #2474

Merged
merged 1 commit into from Jan 30, 2020

Conversation

rob729
Copy link
Contributor

@rob729 rob729 commented Jan 30, 2020

Fixes #2473, #2380

@auto-label auto-label bot added the fix label Jan 30, 2020
@ci-reporter
Copy link

ci-reporter bot commented Jan 30, 2020

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 810ef15. Here's the output:

Run Tests
> Task :assemble UP-TO-DATE

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!


This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

1 similar comment
@ci-reporter
Copy link

ci-reporter bot commented Jan 30, 2020

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 810ef15. Here's the output:

Run Tests
> Task :assemble UP-TO-DATE

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!


This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

@rob729
Copy link
Contributor Author

rob729 commented Jan 30, 2020

@atm1504 @iamareebjamal Can you please re-trigger the ci build as I check for any possible reason for build fail but found none?

@liveHarshit
Copy link
Member

Where is Travis

build.gradle Outdated
@@ -19,6 +19,7 @@ buildscript {

allprojects {
repositories {
jcenter()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did u add jcenter().

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the build was failing and it was showing 7 libraries as failed to resolve.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atm1504 can you please re-trigger the build or help me identify the reason for build fail error?

@rob729
Copy link
Contributor Author

rob729 commented Jan 30, 2020

I don't think susi ai android uses Travis.

@atm1504 @iamareebjamal Can you please re-trigger the ci build as I check for any possible reason for build fail but found none?

@atm1504
Copy link
Member

atm1504 commented Jan 30, 2020

I don't think susi ai android uses Travis.

@atm1504 @iamareebjamal Can you please re-trigger the ci build as I check for any possible reason for build fail but found none?

Susi uses circle ci yml file not travis

@iamareebjamal
Copy link
Member

When compilation fails, do you just retry compiling again or try to fix the error?

@rob729
Copy link
Contributor Author

rob729 commented Jan 30, 2020

The build error is fixed now. Please review the PR.

@iamareebjamal iamareebjamal merged commit fdaf77b into fossasia:development Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump realm-gradle-plugin to 6.1.0 and fix build
4 participants