Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding feature to report a skill #430

Merged
merged 1 commit into from Oct 2, 2018
Merged

Adding feature to report a skill #430

merged 1 commit into from Oct 2, 2018

Conversation

jogendra
Copy link
Member

@jogendra jogendra commented Sep 14, 2018 •
edited

Fixes #429

Changes:

  • User can report skill in Skill Detail screen
  • Only logged-in user can report skill

Screenshots for the change:

@jogendra jogendra added the Feature New feature label Sep 14, 2018
SIMRAN1
SIMRAN1 approved these changes Sep 19, 2018
View reviewed changes
Copy link
Contributor

@SIMRAN1 SIMRAN1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@jogendra jogendra merged commit f724888 into fossasia:master Oct 2, 2018
@jogendra jogendra deleted the report-skill branch October 2, 2018 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anshumanv anshumanv anshumanv approved these changes

@SIMRAN1 SIMRAN1 SIMRAN1 approved these changes

@sansyrox sansyrox sansyrox approved these changes

@arundhatigupta arundhatigupta arundhatigupta approved these changes

@Akshat-Jain Akshat-Jain Akshat-Jain approved these changes

@chashmeetsingh chashmeetsingh Awaiting requested review from chashmeetsingh

@mariobehling mariobehling Awaiting requested review from mariobehling

Assignees
No one assigned
Labels
Feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jogendra @anshumanv @SIMRAN1 @sansyrox @arundhatigupta @Akshat-Jain