Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement action types pause, resume and restart #309

Closed
Orbiter opened this issue Jul 29, 2018 · 5 comments
Closed

Implement action types pause, resume and restart #309

Orbiter opened this issue Jul 29, 2018 · 5 comments
Assignees

Comments

@Orbiter
Copy link
Contributor

Orbiter commented Jul 29, 2018

Describe the solution you'd like
If a media file is played, it is possible to say "stop" to stop playing. Similarly, with the following action types, it should be possible to

  • pause the playing of a media file (youtube, mp3 etc) with the action type pause
  • resume the playing of a media file which has been paused with the action type resume
  • restart the playing of a media file (either currently playing or paused) with the action type restart

Additional context
Examples:
https://api.susi.ai/susi/chat.json?q=pause

"actions": [{"type": "pause"}]

https://api.susi.ai/susi/chat.json?q=resume

"actions": [{"type": "resume"}]

https://api.susi.ai/susi/chat.json?q=restart

"actions": [{"type": "restart"}]
@Orbiter
Copy link
Contributor Author

Orbiter commented Jul 29, 2018

related: fossasia/susi_iOS#395 fossasia/susi_android#1607 the issues for Android and iOS

@sansyrox
Copy link
Member

sansyrox commented Aug 1, 2018

I would like to work on it

@sansyrox sansyrox self-assigned this Aug 1, 2018
@sansyrox
Copy link
Member

sansyrox commented Aug 1, 2018

@Orbiter , right now we pause the Music to process the second query. Now we would have to follow a different approach. Should we be reducing the volume of the music player instead??

@hongquan
Copy link
Member

hongquan commented Aug 3, 2018

have to follow a different approach

@stealthanthrax Can I learn more about the context? Which approach is that? Where is it described?

@tmccormi
Copy link
Contributor

Adding an action to change the volume up and down seems to be relevant for this feature request as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants