Reduced the youtube processing time 90% #391
Conversation
sansyrox
requested review from
hongquan,
cweitat,
mariobehling,
Orbiter and
woshikie
sansyrox
changed the title
|
You are introducing more software to SUSI Linux, so please update the install script to include these software. Please note that, we are using headless Raspbian, so please include Btw, according to #384 (comment), your PR still depends on |
|
@hongquan , the testing is still in process as the PR is still in (WIP) . But how is this PR dependant on Noted, thanks a lot 😄
|
|
I know that you are streaming video. Quote from my comment:
So, why have to add |
|
@hongquan , I am using pafy to retrieve the best mp3 streaming URL and am using the library "python-vlc" to stream the URL. I believe that we can install vlc-nox as well |
|
@stealthanthrax conflict |
|
@cweitat , updated |
Deploy/auto_boot.sh
Outdated
| @@ -10,3 +10,4 @@ cp $DIR_PATH/Systemd/ss-*.service /lib/systemd/system/ | |||
| systemctl enable ss-update-daemon.service | |||
| systemctl enable ss-susi-server.service | |||
| systemctl enable ss-python-flask.service | |||
| systemctl enable ss-susi-youtube.service | |||
youtube_player/music_server.py
Outdated
| return resp | ||
|
|
||
| if __name__ == '__main__': | ||
| app.run(debug=True,port=7070,host= '0.0.0.0') |
|
@hongquan , updated |
sansyrox
changed the title
|
You still don't update what I requested:
|
|
@stealthanthrax Note, I asked you to update install script twice, but you still ignore?? |
|
@hongquan , I am not sure why I need to make any change with the install script |
|
@hongquan , travis fails If I add whitespaces at the end of a line
|
You make SUSI depend on pafy, vlc. If you don't install them to RPi, how can SUSI run?
@stealthanthrax Who told you to "add whitespace at the end of a line"? |
|
@hongquan , then where do I add them ?? 😕
|
|
You have had to fix PEP8 so many times, don't you?
|
|
@stealthanthrax You only add "python-vlc" to requirements file, then from where VLC come, for "python-vlc" to call? |
|
@hongquan , updated |
|
You are about to replace MPV with "VLC", why don't you remove MPV from install script?? And what the hell is this:
You make the checker silent, instead of fixing your error? |
|
If I don't disable the pylint , it won't allow us the run it at '0.0.0.0' which is an essential feature as it will allow us to control the music from mobile clients in the future.
|
|
About issue of binding to It is because, there are many tasks that Nginx can do itself, without needing Python app's effort. Access rate limit (to avoid abusing) is also taken care by Nginx. But in our use case, it seems to be not a time to need Nginx yet. What I complaint in the line app.run(debug=false,port=7070,host= '0.0.0.0')is this issue. Just in this PR, I tell you again and again to fix, but you keep ignoring? |
|
@hongquan , updated |
|
@stealthanthrax How about this?
|
|
@hongquan , updated |
Fixes #384
(Partial Fix to #309 )
Creates a custom media server rather using mpv