Added API to get country wise skill usage data #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akshat-Jain
previously approved these changes
Jun 8, 2018
Akshat-Jain
reviewed
Jun 8, 2018
anshumanv
previously approved these changes
Jun 8, 2018
PrP-11
previously approved these changes
Jun 10, 2018
sansyrox
previously approved these changes
Jun 10, 2018
AnupKumarPanwar
dismissed stale reviews from sansyrox, PrP-11, anshumanv, and Akshat-Jain
via
80bd77e
|
@saurabhjn76 @dynamitechetan @DravitLochan @madhavrathi I think it can be merged now. Please review. |
akshatnitd
requested changes
Jun 11, 2018
src/ai/susi/mind/SusiCognition.java
Outdated
| if (languageName.has(skill_name)) { | ||
| JSONArray countryWiseUsageData = languageName.getJSONArray(skill_name); | ||
| Boolean countryExists = false; | ||
| for (int i = 0; i<countryWiseUsageData.length(); i++) { |
There was a problem hiding this comment.
Add space before and after <
src/ai/susi/mind/SusiCognition.java
Outdated
| Boolean countryExists = false; | ||
| for (int i = 0; i<countryWiseUsageData.length(); i++) { | ||
| JSONObject countryUsage = countryWiseUsageData.getJSONObject(i); | ||
| if (countryUsage.get("country_code").equals(countryCode)){ |
src/ai/susi/mind/SusiCognition.java
Outdated
| JSONObject countryUsage = new JSONObject(); | ||
| countryUsage.put("country_code", countryCode); | ||
| countryUsage.put("country_name", countryName); | ||
| countryUsage.put("count", "1"); |
There was a problem hiding this comment.
Do not use String here, instead use integer
src/ai/susi/mind/SusiCognition.java
Outdated
| countryWiseUsageData.put(countryUsage); | ||
| } | ||
|
|
||
|
|
src/ai/susi/mind/SusiCognition.java
Outdated
| modelName.put(group_name, groupName); | ||
| skillUsage.put(model_name, modelName, true); | ||
| return; | ||
|
|
src/ai/susi/mind/SusiCognition.java
Outdated
| JSONObject countryUsage = new JSONObject(); | ||
| countryUsage.put("country_code", countryCode); | ||
| countryUsage.put("country_name", countryName); | ||
| countryUsage.put("count", "1"); |
| if (modelName.has(group_name)) { | ||
| JSONObject groupName = modelName.getJSONObject(group_name); | ||
| if (groupName.has(language_name)) { | ||
| JSONObject languageName = groupName.getJSONObject(language_name); |
There was a problem hiding this comment.
Remove extra space after JSONObject
src/ai/susi/mind/SusiCognition.java
Outdated
| } | ||
| } | ||
|
|
||
| if (!countryExists) { |
There was a problem hiding this comment.
It is getting redundant here. You can directly use the block that is present outside the if sections. I would suggest you to take a look at FiveStarRateSkillService.java for reference.
|
Also, squash the commits. |
Orbiter
previously approved these changes
Jun 11, 2018
|
please resolve conflicts |
|
@Orbiter Resolved the merge conflicts. Please review. |
|
@mariobehling @Orbiter @saurabhjn76 @dynamitechetan @DravitLochan @madhavrathi @sudheesh001 Please review. Done the required changes. |
dynamitechetan
approved these changes
Jun 12, 2018
This was referenced Jun 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Country wise skill usage analytics #810
Changes:
Endpoint :
/cms/getCountryWiseSkillUsage.json
Parameters :
Screenshots for the change:
countryWiseSkillUsage.json
Sample API call :
/cms/getCountryWiseSkillUsage.json?model=general&group=Knowledge&language=en&skill=ceo
API response
