Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added API to get device wise skill usage data #825

Merged
merged 2 commits into from
Jun 21, 2018
Merged

Added API to get device wise skill usage data #825

merged 2 commits into from
Jun 21, 2018

Conversation

AnupKumarPanwar
Copy link
Member

Fixes
Device wise skill usage stats #818

Changes:

  1. Created DAO object to store device wise skill usage data in deviceWiseSkillUsage.json.
  2. Added updateDeviceWiseUsageData() function in SusiCognition.java to update device wise skill usage data of the used skills.
  3. Created GetDeviceWiseSkillUsageService.java to act as API to retrieve device wise skill usage data of any skill.

Endpoint :
/cms/getDeviceWiseSkillUsage.json

Parameters :

  • model
  • group
  • language
  • skill

Screenshots for the change:

deviceWiseSkillUsage.json
image

Sample API call :
/cms/getDeviceWiseSkillUsage.json?model=general&group=Knowledge&language=en&skill=ceo

API response
image

@mariobehling mariobehling requested review from Orbiter and sudheesh001 and removed request for Orbiter June 14, 2018 06:48
@AnupKumarPanwar AnupKumarPanwar mentioned this pull request Jun 14, 2018
Open
@anshumanv anshumanv mentioned this pull request Jun 15, 2018
Merged
@AnupKumarPanwar
Copy link
Member Author

@isuruAb @dynamitechetan @DravitLochan @Orbiter Please review.

@AnupKumarPanwar
Copy link
Member Author

@mario please review. The cms side PR has already been merged.

akshatnitd
akshatnitd previously approved these changes Jun 19, 2018
View reviewed changes
akshatnitd
akshatnitd reviewed Jun 19, 2018
View reviewed changes
Copy link
Member

@akshatnitd akshatnitd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits.

PrP-11
PrP-11 reviewed Jun 20, 2018
View reviewed changes
Copy link
Member

@PrP-11 PrP-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sqash commits , rest looks good.

@dynamitechetan dynamitechetan merged commit c606360 into fossasia:development Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshatnitd akshatnitd akshatnitd left review comments

@PrP-11 PrP-11 PrP-11 left review comments

@dynamitechetan dynamitechetan dynamitechetan approved these changes

@sudheesh001 sudheesh001 Awaiting requested review from sudheesh001

@Orbiter Orbiter Awaiting requested review from Orbiter

Assignees
No one assigned
Labels
Analytics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AnupKumarPanwar @akshatnitd @dynamitechetan @PrP-11