New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1041:Removed unnecessary imports and unused variables #1042
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1042 +/- ##
=========================================
- Coverage 55.4% 55.4% -0.01%
=========================================
Files 47 47
Lines 1193 1175 -18
Branches 146 144 -2
=========================================
- Hits 661 651 -10
+ Misses 444 439 -5
+ Partials 88 85 -3
Continue to review full report at Codecov.
|
src/app/effects/knowledge.ts
Outdated
@@ -1,10 +1,8 @@ | |||
import { Injectable } from '@angular/core'; | |||
import { Location } from '@angular/common'; | |||
import {Effect, Actions, toPayload} from '@ngrx/effects'; | |||
import {Effect, Actions } from '@ngrx/effects'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are organising imports, please create space before Effect
.
import { async, ComponentFixture, TestBed, fakeAsync } from '@angular/core/testing'; | ||
import { Component, Input, Output } from '@angular/core'; | ||
|
||
import { async, ComponentFixture, TestBed} from '@angular/core/testing'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are organising imports, please create space before TestBed
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Fixes #1041
Checklist
master
branch.Changes proposed in this pull request:
Removed unnecessary and unused variables to optimize app.
Surge Link:https://pr-1042-fossasia-susper.surge.sh