Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1051:Fixed distortion in UI by hiding Tools tab in smaller devices. #1052

Merged
merged 1 commit into from Jun 29, 2018

Conversation

praveenojha33
Copy link
Member

@praveenojha33 praveenojha33 commented Jun 29, 2018

Fixes #1051

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • I have added necessary documentation (if appropriate)
  • Added Surge preview link

Changes proposed in this pull request:

Fixed distortion in UI by hiding Tools tab in smaller devices.
I have also hidden total displayed results under News Tab which I mentioned in my previous PR.

  • image

@praveenojha33
Copy link
Member Author

praveenojha33 commented Jun 29, 2018

@simsausaurabh Please review. Google also hides Tools and Settings Tabs in mobile view. But here it was possible to show settings tab thats why I have shown it.

@codecov
Copy link

codecov bot commented Jun 29, 2018

Codecov Report

Merging #1052 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1052   +/-   ##
=======================================
  Coverage   56.23%   56.23%           
=======================================
  Files          49       49           
  Lines        1227     1227           
  Branches      151      151           
=======================================
  Hits          690      690           
  Misses        446      446           
  Partials       91       91
Impacted Files Coverage Δ
src/app/results/results.component.ts 42.78% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bbd002...6bc39c8. Read the comment docs.

Copy link
Member

@simsausaurabh simsausaurabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mariobehling mariobehling merged commit 3323046 into fossasia:master Jun 29, 2018
@praveenojha33 praveenojha33 deleted the results branch June 29, 2018 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants