Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1117: Fixed hardcoded URL #1119

Merged
merged 2 commits into from Jul 23, 2018
Merged

Conversation

praveenojha33
Copy link
Member

@praveenojha33 praveenojha33 commented Jul 23, 2018

Fixes #1117

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • I have added necessary documentation (if appropriate)
  • Added Surge preview link

Changes proposed in this pull request:

  • Fixed hardcoded url of YaCy,susper.com and other logos.

@codecov
Copy link

codecov bot commented Jul 23, 2018

Codecov Report

Merging #1119 into development will increase coverage by 1%.
The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #1119   +/-   ##
============================================
+ Coverage        55.36%   56.36%   +1%     
============================================
  Files               49       50    +1     
  Lines             1277     1311   +34     
  Branches           155      155           
============================================
+ Hits               707      739   +32     
- Misses             477      480    +3     
+ Partials            93       92    -1
Impacted Files Coverage Δ
src/app/services/autocorrect.service.ts 43.47% <ø> (ø) ⬆️
src/app/services/knowledgeapi.service.ts 56.14% <100%> (+0.78%) ⬆️
src/app/services/news.service.ts 80.64% <100%> (+0.64%) ⬆️
src/app/dropdown/dropdown.component.ts 100% <100%> (ø) ⬆️
src/app/about/about.component.ts 100% <100%> (ø) ⬆️
src/app/services/search.service.ts 41.17% <100%> (+5.69%) ⬆️
src/app/searchsettings/searchsettings.component.ts 63.15% <100%> (+2.04%) ⬆️
src/app/index/index.component.ts 83.33% <100%> (+2.08%) ⬆️
src/assets/url_configuration.ts 100% <100%> (ø)
src/app/services/autocomplete.service.ts 45.94% <100%> (+1.5%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ea923f...cd7102d. Read the comment docs.

</div>

<div class="col-lg-4 col-sm-12 sub-details">
<h5 class="bold">Contribute to our project</h5>
<p>Get involved as an Open Source developer, designer or tester and start your adventure today! Solve an issue or
feature request on our repositories with
<a class="page-link" href="https://github.com/fossasia/susper.com" target="_blank">FOSSASIA</a>. Build up your developer profile and become part of a fantastic community.</p>
<a class="page-link" href="https://github.com/fossasia/{{susperUrl}}" target="_blank">FOSSASIA</a>. Build up your developer profile and become part of a fantastic community.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I search https://github.com/fossasia, then also I would get many of its instance. Could you add it too ?

@praveenojha33
Copy link
Member Author

@simsausaurabh Please review.

Copy link
Member

@simsausaurabh simsausaurabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@mariobehling mariobehling merged commit 368fe9f into fossasia:development Jul 23, 2018
@praveenojha33 praveenojha33 deleted the url branch July 24, 2018 03:44
praveenojha33 added a commit that referenced this pull request Jul 28, 2018
* Fixes #1107: Fixed CORS error by providing a check for empty query (#1108)

* updating pagination bar fixes #1104 (#1110)

* Fixes #1111 and #1112: Sentences do not terminate in infobox (#1113)

* Fixes #1114: Implemented small description for each query (#1115)

* Update README.md

* Fixes #1117: Fixed hardcoded URL (#1119)

* Fixes #1117: Fixed hardcoded URL

* Added field value pair for object.

* Fixes #1116: Fixed streching/squeezing of images (#1120)

* Fixes #1123: Fixed appearance of Intelligence box (#1126)

* Fixes #1121: Links and text length similar to Google (#1127)

* Fixes #1116 #1098: Fixed appearance of images for different browsers and different screen sizes. (#1128)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants