-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#1261)Style Fixes in Privacy Page #1260
Conversation
Codecov Report
@@ Coverage Diff @@
## development #1260 +/- ##
===============================================
- Coverage 54.78% 54.64% -0.15%
===============================================
Files 51 51
Lines 1400 1400
Branches 171 171
===============================================
- Hits 767 765 -2
- Misses 529 533 +4
+ Partials 104 102 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide a screenshot
Waiting for the preview myself 😅 |
open an issue too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not use inline CSS.
@praveenojha33 Done |
@saarthakchats Please update your issue and make it relevant and detailed. As I can see you are fixing problem related to hidden text and wrong class name. Please mention same in issue. |
Don3 @praveenojha33 |
It seems that the fix you did simply removed the underline, which is good to begin with, but I think you should change the stying of the text to make it look like a heading. Also, make the same changes in terms as well as changing styles only in a single place would make it look inconsistent. Good luck @saarthakchats |
all done @AakashMallik |
Fixes #1261
Checklist
master
branch.Changes proposed in this pull request:
Before
![screenshot 2018-12-05 at 2 29 47 pm](https://user-images.githubusercontent.com/24372680/49502045-41f49480-f89a-11e8-8934-f9597066dfba.png)
^^^ There is text behind that footer ^^^![screenshot 2018-12-05 at 2 31 17 pm](https://user-images.githubusercontent.com/24372680/49502162-87b15d00-f89a-11e8-9740-638419ae7e0e.png)
^^^ Unnecessarily looks like a link --> misleading ^^^ ## After