Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix footer #1265

Merged
merged 1 commit into from
Dec 8, 2018
Merged

fix footer #1265

merged 1 commit into from
Dec 8, 2018

Conversation

pythongiant
Copy link
Member

@pythongiant pythongiant commented Dec 5, 2018

Fixes #1264

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • I have added necessary documentation (if appropriate)
  • Added Surge preview link

Changes proposed in this pull request:

  • Fix Footer

@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #1265 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #1265   +/-   ##
============================================
  Coverage        54.73%   54.73%           
============================================
  Files               51       51           
  Lines             1383     1383           
  Branches           170      170           
============================================
  Hits               757      757           
  Misses             524      524           
  Partials           102      102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34c3637...3bdcb99. Read the comment docs.

@saarthakchats
Copy link
Member

Can you provide Before and After screenshots?

@pythongiant
Copy link
Member Author

Can you provide Before and After screenshots?

eh its a small change. just search for something

Copy link
Member

@praveenojha33 praveenojha33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@praveenojha33 praveenojha33 merged commit 4ba4009 into fossasia:development Dec 8, 2018
@pythongiant pythongiant deleted the footer branch December 15, 2018 05:23
@pythongiant pythongiant mentioned this pull request Jan 7, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants