Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1267: Infobox share modal, styling fixes, redundancies removed #1270

Merged
merged 1 commit into from
Dec 8, 2018
Merged

Fixes #1267: Infobox share modal, styling fixes, redundancies removed #1270

merged 1 commit into from
Dec 8, 2018

Conversation

Pipe-Runner
Copy link
Contributor

@Pipe-Runner Pipe-Runner commented Dec 6, 2018

Fixes #1267

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • I have added necessary documentation (if appropriate)
  • Added Surge preview link

Changes proposed in this pull request:

The changes I have made are:

  • Remove redundant code and make use of a more elegant approach.

  • Fix naming for classes and functions.

  • Fix border-radius to and icon size to match that of Google's

  • Fix the position of the box.

  • https://pr-1270-fossasia-susper.surge.sh

Screenshot of the change

screenshot-localhost-4200-2018 12 07-00-57-27

@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #1270 into development will increase coverage by 0.05%.
The diff coverage is 47.05%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1270      +/-   ##
===============================================
+ Coverage        54.78%   54.84%   +0.05%     
===============================================
  Files               51       51              
  Lines             1400     1393       -7     
  Branches           171      171              
===============================================
- Hits               767      764       -3     
  Misses             529      529              
+ Partials           104      100       -4
Impacted Files Coverage Δ
src/app/infobox/infobox.component.ts 59.61% <47.05%> (+7.07%) ⬆️
src/app/services/intelligence.service.ts 75% <0%> (-8.34%) ⬇️
src/app/services/news.service.ts 77.41% <0%> (-3.23%) ⬇️
src/app/results/results.component.ts 43.29% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75f57a8...112dae1. Read the comment docs.

@pythongiant
Copy link
Member

height's too long

@Pipe-Runner
Copy link
Contributor Author

height's too long

Made some space for sharing it on other platforms. But sure, I can reduce it. @pythongiant

@praveenojha33
Copy link
Member

Please remove the unwanted space from bottom.

@Pipe-Runner
Copy link
Contributor Author

screenshot-localhost-4200-2018 12 07-20-25-21

Made the required changes.

Copy link
Member

@pythongiant pythongiant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pipe-Runner
Copy link
Contributor Author

Works fine for me.

screenshot-pr-1270-fossasia-susper surge sh-2018 12 07-22-50-36
@pythongiant

@pythongiant
Copy link
Member

Works fine for me.

screenshot-pr-1270-fossasia-susper surge sh-2018 12 07-22-50-36
@pythongiant

Yup It was my bad

@praveenojha33 praveenojha33 merged commit c298117 into fossasia:development Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants