-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1267: Infobox share modal, styling fixes, redundancies removed #1270
Fixes #1267: Infobox share modal, styling fixes, redundancies removed #1270
Conversation
Codecov Report
@@ Coverage Diff @@
## development #1270 +/- ##
===============================================
+ Coverage 54.78% 54.84% +0.05%
===============================================
Files 51 51
Lines 1400 1393 -7
Branches 171 171
===============================================
- Hits 767 764 -3
Misses 529 529
+ Partials 104 100 -4
Continue to review full report at Codecov.
|
height's too long |
Made some space for sharing it on other platforms. But sure, I can reduce it. @pythongiant |
Please remove the unwanted space from bottom. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Works fine for me. |
Yup It was my bad |
Fixes #1267
Checklist
master
branch.Changes proposed in this pull request:
The changes I have made are:
Remove redundant code and make use of a more elegant approach.
Fix naming for classes and functions.
Fix border-radius to and icon size to match that of Google's
Fix the position of the box.
https://pr-1270-fossasia-susper.surge.sh
Screenshot of the change