Fixes #1310: Travis issue fixed

[Pipe-Runner]

Fixes #1310

Checklist

• I have read the Contribution & Best practices Guide and my PR follows them.
• My branch is up-to-date with the Upstream master branch.
• I have added necessary documentation (if appropriate)
• Added Surge preview link

Changes proposed in this pull request:

• I have reused hidden instead of ngIf

• https://pr-1316-fossasia-susper.surge.sh

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (development@59481bb). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             development   #1316   +/-   ##
=============================================
  Coverage               ?   54.9%           
=============================================
  Files                  ?      51           
  Lines                  ?    1417           
  Branches               ?     175           
=============================================
  Hits                   ?     778           
  Misses                 ?     534           
  Partials               ?     105

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59481bb...10d5904. Read the comment docs.

[subhahu123]

what is ngif

[Pipe-Runner]

what is ngif

@subhahu123 ?? Angular directive. Sorry I didn't get the context of this question. Was it something else you wanted to ask?

[subhahu123]

i have seen your changes but ended up with nothing (i don't know much about angular)
what was problem in travis cl and what have u done to fix .
just an overview
@AakashMallik

[Pipe-Runner]

i have seen your changes but ended up with nothing (i don't know much about angular)
what was problem in travis cl and what have u done to fix .
just an overview
@AakashMallik

It was caused because [hidden] just sets the display to 0 while ngIf removes the node completely. The tests check whether or not those nodes are available in the DOM tree. So, when ngIf was used, it was unable to find that node. That is why travis was failing.

[rajvaibhavdubey]

Changes LGTM 👍 , though the indentation is not uniform throughout the file.

[shreyanshdwivedi]

LGTM 👍