Fixed clear search issue #1230 #1343
Conversation
Codecov Report
@@ Coverage Diff @@
## development #1343 +/- ##
===============================================
- Coverage 54.89% 54.87% -0.03%
===============================================
Files 51 51
Lines 1419 1425 +6
Branches 176 177 +1
===============================================
+ Hits 779 782 +3
- Misses 534 536 +2
- Partials 106 107 +1
Continue to review full report at Codecov.
|
|
@simsausaurabh @mariobehling Please review. Thanks. |
| } from '@angular/core'; | ||
| import { ActivatedRoute, Router } from '@angular/router'; | ||
| import { Store } from '@ngrx/store'; | ||
| import * as fromRoot from '../reducers'; |
There was a problem hiding this comment.
Why changing to double quotes? Its standard used in project.
There was a problem hiding this comment.
Aah! I just checked. Was a problem with my vscode. Just fixed it and pushed the code. Can you please check and review again?
Fixed double quotes to single quotes Fixed reference for navbar html Fixed spacing issues in constructor scope Fixed clear search issue fossasia#1230
reeversedev
force-pushed
the
1230-input-fixed
branch
from
88b040e
to
6fe943f
Compare
|
@shreyanshdwivedi Just squashed the commits. Are we good to go? |
|
@reeversedev I'll suggest you to add proper test for the function you added. We are working to increase the coverage of every component and your PR decreases coverage of |
|
@shreyanshdwivedi Alright. I'll create a separate issue for that. Till that can you put this in WIP tag? |
|
@reeversedev we can proceed by merging this if maintainers are okay with your pull request. Afterwards, you can create an issue and work on that and create a separate PR for refactoring and increasing code coverage :) |
|
@shreyanshdwivedi Yeah. Let's see if mentors are good to go with this. |
Fixes #1230
Checklist
masterbranch.Changes proposed in this pull request: