Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On help page when hover on close button cursor is pointer #1435

Merged
merged 2 commits into from Mar 8, 2019

Conversation

samagragupta
Copy link
Member

@samagragupta samagragupta commented Jan 26, 2019

Fixes #1434

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • I have added necessary documentation (if appropriate)
  • Added Surge preview link

Changes proposed in this pull request:

-When hover on close button of help page cursor is pointer

cursor

Copy link
Member

@neeraj3029 neeraj3029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the travis build, rest looks good.

@samagragupta
Copy link
Member Author

samagragupta commented Feb 2, 2019

@praveenojha33 @Orbiter @mariobehling Please review.

Copy link
Member

@praveenojha33 praveenojha33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix Travis.

Copy link
Member

@simsausaurabh simsausaurabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIx travis issue, then it will be good to go.

@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #1435 into development will increase coverage by 0.76%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1435      +/-   ##
===============================================
+ Coverage         61.3%   62.06%   +0.76%     
===============================================
  Files               51       51              
  Lines             1455     1450       -5     
  Branches           180      181       +1     
===============================================
+ Hits               892      900       +8     
+ Misses             454      439      -15     
- Partials           109      111       +2
Impacted Files Coverage Δ
src/app/reducers/knowledge.ts 53.33% <0%> (-5.5%) ⬇️
src/app/reducers/speech.ts 66.66% <0%> (-3.34%) ⬇️
src/app/speechtotext/speechtotext.component.ts 42.85% <0%> (-2.86%) ⬇️
src/app/reducers/query.ts 78.94% <0%> (-1.06%) ⬇️
src/app/actions/speech.ts 66.66% <0%> (ø) ⬆️
src/app/actions/query.ts 100% <0%> (ø) ⬆️
src/app/reducers/index.ts 93.75% <0%> (ø) ⬆️
src/app/actions/search.ts 55.55% <0%> (ø) ⬆️
src/app/actions/knowledge.ts 57.14% <0%> (ø) ⬆️
src/app/results/results.component.ts 46.82% <0%> (+1.46%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6de390...2eea939. Read the comment docs.

@samagragupta
Copy link
Member Author

@simsausaurabh @praveenojha33 Fixed the travis

@simsausaurabh simsausaurabh merged commit fd57cb4 into fossasia:development Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cursor should be pointer when hover on close button
5 participants