Fixes #564 now susper answers questions #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshit98
reviewed
Jun 28, 2017
src/app/intelligence.service.ts
Outdated
| let params = new URLSearchParams(); | ||
| params.set('q', searchquery); | ||
| // params.set('QueryClass', 'MaxHits=5'); | ||
|
|
There was a problem hiding this comment.
Remove the comment also. There is no need to add QueryClass and MaxHits in future. We won't be using them.
harshit98
reviewed
Jun 28, 2017
| } | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Single space only. You're giving too much space here.
harshit98
reviewed
Jun 28, 2017
| @@ -0,0 +1,3 @@ | |||
| <div class="card" *ngIf="answer"> | |||
| {{this.answer}} | |||
harshit98
reviewed
Jun 28, 2017
| this.actions = res.answers[0].actions; | ||
| for (let action of this.actions){ | ||
| if (action.type === 'answer' && action.mood !== 'sabta') { | ||
| this.answer = action.expression; |
There was a problem hiding this comment.
this is some random mood name given in susi when the results are not sure, hence whenever mood is sabta, didn't display the result.
harshit98
reviewed
Jun 28, 2017
| this.wholequery$ = store.select(fromRoot.getwholequery); | ||
| this.wholequery$.subscribe(data => { | ||
| this.intelligence.getintelligentresponse(data.query).subscribe(res => { | ||
| console.log(res, res.answers , res.answers[0]); |
There was a problem hiding this comment.
remove console.log to avoid console errors.
|
@nikhilrayaprolu Awesome! 💯 Kindly go through my requested changes. :) |
|
@harshit98 made the requested changes. |
harshit98
approved these changes
Jun 28, 2017
|
Great job. I see travis is failing also on live site. Please help to solve it in subsequent PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #564
This is basic implementation of Intelligence which answers only for questions. this could be incrementally developed with new features like displaying charts, maps etc. and UI changes could be done.
Demo Link: https://susper-pr-569.herokuapp.com/
Screenshots for the change:
