Fix migration timestamp column data type issue #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoMagdaleno
approved these changes
Oct 15, 2021
|
@Flam3rboy It should probably still be a bigint, if it's holding a UNIX Timestamp. |
|
BigInts are not supported by sqlite, we need to find a solution. Either ditch sqlite or maybe save it as string? |
|
SQLite does support 64-bit integers, which is really all we need in terms of integers. |
|
@erkinalp what is the sqlite data type called? REAL is floating point number and not a 64 bit integer. |
|
@Flam3rboy INTEGER in SQLite 3. |
MaddyUnderStars
pushed a commit
that referenced
this pull request
Mar 1, 2023
Fix migration timestamp column data type issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into an issue when trying to run migrations on Postgres where it was trying to allocate too many digits to an integer. This changes that data type to a bigint to resolve that problem.