Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add float for intervals + Add NetSpeed Compact and TotalNetSpeed #100

Merged
merged 8 commits into from
Nov 17, 2020
Merged

Add float for intervals + Add NetSpeed Compact and TotalNetSpeed #100

merged 8 commits into from
Nov 17, 2020

Conversation

prateekmedia
Copy link
Contributor

@prateekmedia prateekmedia commented Nov 5, 2020

This PR is for adding that functionality of floats in intervals, also it will not impact performance cause anyone cannot enter value less than 1 sec(< 1 sec was causing the real performance issue).

Second thing I added was Compact net Speed which basically is UP+DOWN and Total net speed with sigma in front of it which basically is TOTAL UP+TOTAL DOWN, which will help users to track their download and upload speed more effectively. Below is the preview in ubuntu budgie
image

IMO MiB and GiB looks ugly so if you can simply rename them to MB or GB that can be good but again its personal opinion , I have included this in this PR. I have also changed conversion rate from 1MiB=1024 KiB to 1MB = 1024KB

@prateekmedia prateekmedia changed the title Add float for intervals so that refresh time can be 1.5 or 2.4 sec something like that Add float for intervals + Add NetSpeed Compact and TotalNetSpeed Nov 5, 2020
@fossfreedom
Copy link
Owner

fossfreedom commented Nov 7, 2020

The PR looks ok from a quick read.

However remember KiB is not the same as KB ... different number of bytes.

Think probably a separate option is needed to change the calculation of KiB vs KB for example - that's a different issue.

So if you can back out those changes please I can merge.

@prateekmedia
Copy link
Contributor Author

The PR looks ok from a quick read.

However remember KiB is not the same as KB ... different number of bytes.

Think probably a separate option is needed to change the calculation of KiB vs KB for example - that's a different issue.

So if you can back out those changes please I can merge.

Sure Maybe in one or two days, I will get back to you when I'm done. 👍

@prateekmedia
Copy link
Contributor Author

So if you can back out those changes please I can merge.

DONE :), I tried my best to make a method or function of common code but I couldn't, else everything is perfect I think.

PS : used 1KB = 1000B

@prateekmedia

This comment has been minimized.

@prateekmedia
Copy link
Contributor Author

So if you can back out those changes please I can merge.

Are You their? @fossfreedom

@fossfreedom fossfreedom merged commit 78ca787 into fossfreedom:master Nov 17, 2020
@fossfreedom
Copy link
Owner

LGTM - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants