Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Enhancements for Dynamic Theme #86

Closed
5 tasks done
SpaceFrrog opened this issue Jan 19, 2024 · 1 comment
Closed
5 tasks done

Design Enhancements for Dynamic Theme #86

SpaceFrrog opened this issue Jan 19, 2024 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@SpaceFrrog
Copy link

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Is your feature request related to a problem? Please describe.
It is not related to a problem, but I would suggest a change to the design! The current colors of the dynamic themes do not correspond to those in the Material Design Guidelines.

Describe the solution you'd like
They are much lighter than described there. For example, the background color of the FAB is A1-400 in dark mode, but according to the Material Guidelines it should be A1-700. I would be happy if this could be adjusted for all components of the app.

Additional context
Add any other context or screenshots about the feature request here.

https://m3.material.io/theme-builder#/dynamic
Calendar_Colors
Color_Chips

@SpaceFrrog SpaceFrrog added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jan 19, 2024
@Aga-C
Copy link
Member

Aga-C commented Jan 19, 2024

Please add your remarks to the general issue about dynamic theme: #41.

@Aga-C Aga-C closed this as completed Jan 19, 2024
@Aga-C Aga-C added duplicate This issue or pull request already exists and removed feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jan 19, 2024
@Aga-C Aga-C closed this as not planned Won't fix, can't repro, duplicate, stale Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants