Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor contrast on selected main icon when changing the base color of the app on dark mode #57

Closed
6 of 7 tasks
GabrielCanaple opened this issue Feb 15, 2024 · 1 comment
Labels
invalid This does not seem right

Comments

@GabrielCanaple
Copy link

GabrielCanaple commented Feb 15, 2024

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.
  • I optionally donated to support the Fossify mission.

Feature description

I want better contrast between the selected main icon and the rest of the app on dark mode with any chosen color.

Why do you want this feature?

When using dark mode and changing the base color of the app (green) to another one (for example purple) the contrast between the current selected icon and its text and the background isn't very good. See attachment to understand what I am talking about.
Screenshot_20240215_232213_org fossify filemanager copy
This can be problematic as the text and the icon are hardly distinguishable from the background.

Additional information

No response

@Aga-C
Copy link
Member

Aga-C commented Feb 15, 2024

It's the same color palette for each theme. You can even select black primary color for dark mode or white for light mode. It's up to the users what color they choose and is it contrasting enough.

@Aga-C Aga-C closed this as not planned Won't fix, can't repro, duplicate, stale Feb 15, 2024
@Aga-C Aga-C added invalid This does not seem right and removed feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This does not seem right
Projects
None yet
Development

No branches or pull requests

2 participants