Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Import SPDX Spreadsheet in SRC tab #184

Merged
merged 3 commits into from
Oct 15, 2021
Merged

Support Import SPDX Spreadsheet in SRC tab #184

merged 3 commits into from
Oct 15, 2021

Conversation

kimtaehyun98
Copy link
Contributor

@kimtaehyun98 kimtaehyun98 commented Oct 10, 2021

Support Import SPDX Spreadsheet in SRC Tab.

1) Column mapping for import SPDX Spreadsheet

  • Do column mapping because of SPDX Spreadsheet column is different from that of Excel.

    Package Info

      - Package Name : OSS Name
      - Package version : OSS version
      - Package Download location : Download location
      - Homepage: Homepage
      - License Concluded : License
         - The License value itself is output in the Comment Column.
      - Package Copyright Text : Copyright text
    

    Per File Info

      - File Name : Source Name or Path, Binary Name
      - Package Identifier : Read this value and read the following values ​​from the same row with the SPDX Identifier in the Package Info sheet
          - Package Name : OSS Name
          - Package Version : OSS Version
          - Package Download location : Download location 
          - Homepage: Homepage
     - License Concluded : License
     - File Copyright text : Copyright text
    

2) SPDX Spreadsheet License List parsing

  • SPDX Spreadsheet Licenses are expression by '(', ')' 'AND', 'OR'.
  • In the License field, remove the parentheses () and divide all Licenses based on AND OR to load.
    ex) (A_LIC AND B_LIC) works the same as uploading by entering A_LIC and B_LIC in Excel
    • If the License is NONE or NOASSERTION, it is loaded as blank.

image

3) Assign Packaging Info, Per file info sheet to default sheet when import SPDX Spreadsheet

  • If import SPDX Spreadsheet, user don't need to check sheet.
  • Automatically Packaging Info, Per file info sheet is selected and analysis the file.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@soimkim soimkim added the enhancement [PR/Issue] New feature or request label Oct 10, 2021
@kimtaehyun98 kimtaehyun98 changed the title Support Import SPDX Spreadsheet Support Import SPDX Spreadsheet in SRC tab Oct 12, 2021
@kimtaehyun98
Copy link
Contributor Author

@riyenas0925 @hyewoncc
review please 😊

Signed-off-by: Taehyun <kimtaehyun98@naver.com>
Signed-off-by: Taehyun <kimtaehyun98@naver.com>
…rt SPDX Spreadsheet

Signed-off-by: Taehyun <kimtaehyun98@naver.com>
@kimtaehyun98
Copy link
Contributor Author

@riyenas0925
Resolve all convention review. Thanks to Review! 😁

@hyewoncc
Copy link
Contributor

All things worked well for me! I can see through codes that you thought a lot to make this work... really great job! 😄

@soimkim
Copy link
Contributor

soimkim commented Oct 15, 2021

@kimtaehyun98 , It's awesome! 👍

One thing I'm curious about is the code reads the "File Name", but why isn't it loaded in "Source Name or Path"?
image

@soimkim
Copy link
Contributor

soimkim commented Oct 15, 2021

Let's F/U separately for the comments I left!

@soimkim soimkim merged commit a00feb8 into fosslight:develop Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [PR/Issue] New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants