Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return value to Obligation Type #607

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

myway00
Copy link
Contributor

@myway00 myway00 commented Jul 28, 2022

Signed-off-by: myway00 junior0614@naver.com

Description

#545

- `History List > Modify Type: Open Source > Obligation` was shown as `000` (default Code type of Obligation) regardless of its type.

image

- Obligation Code value is now shown as its type.

image

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Signed-off-by: myway00 <junior0614@naver.com>
@soimkim soimkim added the bug fix [PR] Fix the bug label Jul 29, 2022
Signed-off-by: myway00 <junior0614@naver.com>
@myway00 myway00 force-pushed the bugfix/proper-return-value branch from 6db1fb0 to 8438488 Compare July 29, 2022 16:36
@myway00 myway00 requested a review from soimkim August 2, 2022 03:09
@soimkim soimkim merged commit 2b9b1a2 into fosslight:develop Aug 5, 2022
@myway00 myway00 deleted the bugfix/proper-return-value branch September 13, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix [PR] Fix the bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

History List > Modify Type: Open Source > Obligation always saved as 000.
2 participants