Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): sanitize the names of api functions #119

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Conversation

Shruti3004
Copy link
Collaborator

@Shruti3004 Shruti3004 commented Jul 21, 2021

Description

Fixed all the api function names.

How to test

Check all the requests.

@shaheemazmalmmd shaheemazmalmmd added needs review Need code review needs test Needs testing labels Jul 22, 2021
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@GMishx GMishx removed the needs review Need code review label Jul 22, 2021
@github-actions
Copy link

This pull request has conflicts, please rebase to resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the has merge conflicts PR has merge conflicts, require rebase label Jul 23, 2021
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No errors while testing.

@GMishx GMishx added ready PR is ready for merge and removed needs test Needs testing labels Jul 23, 2021
Signed-off-by: Shruti3004 <mail2shruti.ag@gmail.com>
@Shruti3004
Copy link
Collaborator Author

@GMishx rebased the pr.

@GMishx GMishx merged commit a48144b into development Jul 23, 2021
@GMishx GMishx deleted the fix/api-names branch July 23, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has merge conflicts PR has merge conflicts, require rebase ready PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants