Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(copyright): add copyright table #147

Merged
merged 3 commits into from
Aug 18, 2021
Merged

Conversation

Aman-Codes
Copy link
Collaborator

@Aman-Codes Aman-Codes commented Aug 10, 2021

Description

Added react-table library (MIT license) for table in copyright.

Changes

  • Created copyright table using react-table library
  • Added pagination
  • Added sorting
  • Added button to deactivate copyright
  • Added test cases for the added code

Screenshots

image
CPT2108101457-1516x670A
image

How to test

Go to http://localhost:3000/browse/copyright

Signed-off-by: Aman Dwivedi <aman.dwivedi5@gmail.com>
@GMishx GMishx added needs review Need code review needs test Needs testing labels Aug 10, 2021
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@GMishx GMishx removed the needs review Need code review label Aug 10, 2021
@GMishx
Copy link
Member

GMishx commented Aug 12, 2021

Unable to read text in dark theme. Please fix.

Signed-off-by: Aman Dwivedi <aman.dwivedi5@gmail.com>
@Aman-Codes
Copy link
Collaborator Author

Unable to read text in dark theme. Please fix.

Fixed it now

Signed-off-by: Aman Dwivedi <aman.dwivedi5@gmail.com>
@GMishx GMishx merged commit 5ec30e0 into development Aug 18, 2021
@GMishx GMishx deleted the feat/browse-uploads branch August 18, 2021 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs test Needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants