Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(delete user): Disabled deletion of default users #196

Conversation

krishna9304
Copy link
Contributor

Description

This PR is in reference to the issue #195 and discussion on preventing the deletion of default users.

Changes Done

  • Greyed out the default users in the dropdown.
  • Added the feature to set defaults for delete user data so that the api request doesn't go invalid.

Screenshots

ss2.mov

This PR closes #195.

@krishna9304
Copy link
Contributor Author

@GMishx can you review this?

@GMishx GMishx added needs review Need code review needs test Needs testing labels Mar 30, 2022
Greyed out the default users in the dropdown. I also added the code to set defaults for delete user data

Signed-off-by: Krishna Mahato <krishhtrishh9304@gmail.com>
@krishna9304 krishna9304 force-pushed the krishna9304/195/delete-user-button-throws-error branch from 071628f to cae0ed1 Compare March 30, 2022 10:20
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@GMishx GMishx removed the needs review Need code review label Mar 30, 2022
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

@GMishx GMishx merged commit 24dbfa8 into fossology:main May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs test Needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on delete user button throws error
3 participants