Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(route): fixed the linking of routes #20

Merged
merged 1 commit into from
Jun 24, 2021
Merged

fix(route): fixed the linking of routes #20

merged 1 commit into from
Jun 24, 2021

Conversation

Shruti3004
Copy link
Collaborator

@Shruti3004 Shruti3004 commented Jun 22, 2021 •
edited

Description

Updated the linking of routes in Header.

Changes

  • updated the Header page routing.
  • Replace the href to Link so that it doesn't refreshes the pages on each render of the component.

How to test

Visit to all the routes /, /login, /help/overview, /help/licenseBrowser

@Shruti3004
fix(route): fixed the linking of routes
e69cfe9 
Signed-off-by: Shruti3004 <mail2shruti.ag@gmail.com>
GMishx
GMishx approved these changes Jun 24, 2021
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@GMishx GMishx merged commit 4cd6e79 into development Jun 24, 2021
@GMishx GMishx deleted the fix/routes branch June 24, 2021 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMishx GMishx GMishx approved these changes

@Aman-Codes Aman-Codes Awaiting requested review from Aman-Codes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Shruti3004 @GMishx