Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Updated dependencies #206

Merged
merged 1 commit into from
May 30, 2022
Merged

chore(deps): Updated dependencies #206

merged 1 commit into from
May 30, 2022

Conversation

soham4abc
Copy link
Contributor

Signed-off-by: soham4abc sohambanerjee4abc@hotmail.com

Description

This PR has updated dependencies which are backward compatible

Changes

package.json and yarn.lock

How to test

Run npm i or yarn install to get the updated dependencies installed.

@shaheemazmalmmd Please do have a look

@soham4abc soham4abc requested a review from GMishx May 25, 2022 12:25
@GMishx GMishx added needs review Need code review needs test Needs testing labels May 30, 2022
GMishx
GMishx approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@GMishx GMishx removed the needs review Need code review label May 30, 2022
@GMishx
Copy link
Member

GMishx commented May 30, 2022

Can you please change the title of the commit to something like chore(deps): updated dependencies to be inline with contributing guidelines @soham4abc?

@soham4abc soham4abc changed the title Updated dependenceis with backward compatibility chore(deps): Updated dependencies May 30, 2022
@soham4abc
Copy link
Contributor Author

Can you please change the title of the commit to something like chore(deps): updated dependencies to be inline with contributing guidelines @soham4abc?

Done as per request sir!

GMishx
GMishx approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

@GMishx GMishx added ready PR is ready for merge and removed needs test Needs testing labels May 30, 2022
@GMishx
Copy link
Member

GMishx commented May 30, 2022 •
edited

Can you please change the title of the commit to something like chore(deps): updated dependencies to be inline with contributing guidelines @soham4abc?

Done as per request sir!

@soham4abc , you updated the PR title, the commit is still the same. Please ammend your commit and do a force push on the branch.

image

@soham4abc
Copy link
Contributor Author

Can you please change the title of the commit to something like chore(deps): updated dependencies to be inline with contributing guidelines @soham4abc?

Done as per request sir!

@soham4abc , you updated the PR title, the commit is still the same. Please ammend your commit and do a force push on the branch.

image

Sorry sir My Bad! Did it as per you said. Do let me know if anything else is required.

@GMishx GMishx merged commit 69d5286 into fossology:main May 30, 2022
@soham4abc soham4abc deleted the dependencies-upgrade branch May 30, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMishx GMishx GMishx approved these changes

Assignees
No one assigned
Labels
ready PR is ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@soham4abc @GMishx