Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exported constants from upload directory and reused them #219

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

soham4abc
Copy link
Contributor

Description

Exported the constants that were being used in the Upload directory and reused them where ever same constants were being used.

Changes

src/pages/upload

How to test

Run the Front-end with the latest backend and try to upload files using different methods

Fixes #108

@soham4abc
Copy link
Contributor Author

PTAL @GMishx @shaheemazmalmmd @sjha2048

@GMishx GMishx added needs review Need code review needs test Needs testing labels Jun 13, 2022
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. Needs test.

@GMishx GMishx removed the needs review Need code review label Jun 13, 2022
@GMishx
Copy link
Member

GMishx commented Jun 13, 2022

@soham4abc please update your commit message according to Contributing guidelines.

@soham4abc
Copy link
Contributor Author

@soham4abc please update your commit message according to Contributing guidelines.

Done sir!

@soham4abc soham4abc requested a review from GMishx June 13, 2022 05:02
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

@GMishx GMishx added ready PR is ready for merge and removed needs test Needs testing labels Jun 13, 2022
@GMishx GMishx merged commit 37057e1 into fossology:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor large components
2 participants