Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(ui): ui and formdata implementation for the add user page #229

Merged
merged 1 commit into from Aug 25, 2022

Conversation

krishna9304
Copy link
Contributor

@krishna9304 krishna9304 commented Jun 19, 2022

Signed-off-by: Krishna Mahato krishhtrishh9304@gmail.com

Description

Ui and API Implementation is done for the Add User page.

Screenshots and UI Demo

Screen.Recording.2022-09-04.at.3.29.00.PM.mov

How to test

In the UI Go to Admin > Users > Add User

This closes #224 .
PTAL : @shaheemazmalmmd @sjha2048 @GMishx @Shruti3004

@krishna9304 krishna9304 changed the title add: ui and formdata implementation for the add user page add: ui and formdata implementation for the add user page Jun 19, 2022
@krishna9304 krishna9304 changed the title add: ui and formdata implementation for the add user page feature(ui): ui and formdata implementation for the add user page Jun 19, 2022
@GMishx
Copy link
Member

GMishx commented Jun 21, 2022

Please update the commit message to be compliant with convention.

feat(ui): ui and formdata implementation for the add user page

@krishna9304
Copy link
Contributor Author

Please update the commit message to be compliant with convention.

feat(ui): ui and formdata implementation for the add user page

On it!

Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working as expected.

Just had few question if you can answer @krishna9304

src/pages/Admin/Users/Add/index.jsx Outdated Show resolved Hide resolved
src/pages/Admin/Users/Add/index.jsx Outdated Show resolved Hide resolved
@GMishx GMishx added question Further information is requested ready PR is ready for merge and removed needs test Needs testing needs review Need code review labels Jun 23, 2022
@krishna9304 krishna9304 force-pushed the ui/add-user-page branch 2 times, most recently from e56e637 to 6666f9f Compare June 23, 2022 16:58
src/pages/Admin/Users/Add/index.jsx Outdated Show resolved Hide resolved
src/pages/Admin/Users/Add/index.jsx Outdated Show resolved Hide resolved
@GMishx GMishx added needs review Need code review and removed question Further information is requested ready PR is ready for merge labels Jun 28, 2022
@krishna9304 krishna9304 force-pushed the ui/add-user-page branch 2 times, most recently from 2499628 to f300cd5 Compare June 30, 2022 19:45
@krishna9304 krishna9304 requested a review from GMishx June 30, 2022 19:55
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

Needs REST API to test.

@GMishx GMishx added needs test Needs testing and removed needs review Need code review labels Jul 2, 2022
Signed-off-by: Krishna Mahato <krishhtrishh9304@gmail.com>
@krishna9304
Copy link
Contributor Author

krishna9304 commented Aug 2, 2022

Added REST API, Need to install the api from this PR fossology/fossology#2256 to test.
@GMishx Please have a look.

@krishna9304 krishna9304 requested a review from GMishx August 2, 2022 09:55
@shaheemazmalmmd shaheemazmalmmd merged commit 4bf185e into fossology:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs test Needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creation of Add user page
3 participants