Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): implementation of mantainance page on the admin section #232

Merged
merged 1 commit into from Jun 23, 2022
Merged

feat(ui): implementation of mantainance page on the admin section #232

merged 1 commit into from Jun 23, 2022

Conversation

dushimsam
Copy link
Contributor

@dushimsam dushimsam commented Jun 20, 2022 •
edited

Signed-off-by: dushimsam dushsam100@gmail.com

Description

Implemented the maintenance page from the Admin section. The page is on the route /admin/mantainance

Changes

  1. Created a new directory ,src/pages/admin/Mantainance/index.jsx
  2. Imported and added the new page in the src/Routes.jsx as a part of AdminLayout
  3. Added a new navigation dropdown Item as a part of the admin dropdowns.
  4. Added the route and initial field values for the new page in src/constants/routes.js.

How to test

  1. Go in the project's main directory.
  2. run command npm start
  3. Visit the page at http://localhost:PORT/admin/mantainance
  4. You should see something looking like this

##Screenshots
Selection_006
Selection_007

Related Issue:

Fixes #227

@shaheemazmalmmd @GMishx

@dushimsam dushimsam force-pushed the dushimsam/feat/admin/mantainance branch 2 times, most recently from c781e73 to fb1352a Compare June 21, 2022 07:44
@GMishx
Copy link
Member

GMishx commented Jun 21, 2022

Please consider uploading images directly to PR description. We do not see them due to permission issue
image

GMishx
GMishx requested changes Jun 21, 2022
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the .idea folder from commit.

src/constants/routes.js Outdated Show resolved Hide resolved
src/pages/Admin/Mantainance/index.jsx Outdated Show resolved Hide resolved
src/pages/Admin/Mantainance/index.jsx Outdated Show resolved Hide resolved
@dushimsam dushimsam force-pushed the dushimsam/feat/admin/mantainance branch 3 times, most recently from 7c8cd13 to 222b471 Compare June 21, 2022 14:07
@dushimsam
feat(ui): implementation of mantainance page on the admin section
9f05b81 
Signed-off-by: dushimsam <dushsam100@gmail.com>
@dushimsam dushimsam force-pushed the dushimsam/feat/admin/mantainance branch from 222b471 to 9f05b81 Compare June 21, 2022 14:09
@dushimsam
Copy link
Contributor Author

dushimsam commented Jun 21, 2022 •
edited

I have now resolved all queries sir.
You can review it.

@GMishx GMishx added needs review Need code review needs test Needs testing labels Jun 23, 2022
GMishx
GMishx approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. Tested, working as expected.

@GMishx GMishx added ready PR is ready for merge and removed needs review Need code review needs test Needs testing labels Jun 23, 2022
@GMishx GMishx merged commit 183ab4e into fossology:main Jun 23, 2022
@dushimsam
Copy link
Contributor Author

that's awesome 👍
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMishx GMishx GMishx approved these changes

Assignees
No one assigned
Labels
ready PR is ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creation of maintanance page
2 participants
@dushimsam @GMishx