Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(UI): Upload permissions page UI and API Implementation done #251

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(UI): Upload permissions page UI and API Implementation done #251

wants to merge 1 commit into from

Conversation

krishna9304
Copy link
Contributor

@krishna9304 krishna9304 commented Aug 14, 2022 •
edited

Description

Ui and API Implementation of the Upload Permissions page.

Tasks Done

  • Create the static UI.
  • Implement data retrieval from html forms.
  • Implement the new API in PR #2275.
  • Test everything.

Demo Screenshots

final.mp4

How to test

  • Install the API from -> #2275 in the fossology backend.
  • In the UI Go to admin>Upload Permissions
  • The route is available at /admin/upload-permissions

cc: @Shruti3004 @GMishx
This closes #247 .

@github-actions github-actions bot added the has merge conflicts PR has merge conflicts, require rebase label Aug 25, 2022
@github-actions
Copy link

This pull request has conflicts, please rebase to resolve those before we can evaluate the pull request.

@shaheemazmalmmd
Copy link
Collaborator

@krishna9304 : UI looks good. except that I'm facing issue with adding user to upload who is not first. Page reload every time is causing this can you please check ?

@krishna9304
Copy link
Contributor Author

@krishna9304 : UI looks good. except that I'm facing issue with adding user to upload who is not first. Page reload every time is causing this can you please check ?

yes, there are some changes in the backend that's causing this issue. I'll fix this and update the PR.

@shaheemazmalmmd shaheemazmalmmd added needs review Need code review needs test Needs testing labels Aug 26, 2022
@github-actions github-actions bot removed the has merge conflicts PR has merge conflicts, require rebase label Aug 29, 2022
@krishna9304
Copy link
Contributor Author

Fixed the issues and updated the PR. PTAL @shaheemazmalmmd .

@krishna9304
Copy link
Contributor Author

resolved conflicts @shaheemazmalmmd .

@shaheemazmalmmd
Copy link
Collaborator

@krishna9304 While testing i have found that i was not able to render the groups also the public permissions has been changed to user permission. please not that public permissions here are specific to upload not to user.

@krishna9304
Copy link
Contributor Author

@krishna9304 While testing i have found that i was not able to render the groups also the public permissions has been changed to user permission. please not that public permissions here are specific to upload not to user.

Update the PR. PTAL at the recent changes. @shaheemazmalmmd

@shaheemazmalmmd
Copy link
Collaborator

@krishna9304 I have tested the Pull request and i still see the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs review Need code review needs test Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(UI) Creation of the upload permissions Page
2 participants
@krishna9304 @shaheemazmalmmd