Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integration): Integrated the fossology maintenance page. #252

Conversation

dushimsam
Copy link
Contributor

@dushimsam dushimsam commented Aug 15, 2022

Description

Integrated the Fossology maintenance page to the REST API in charge of activating the maintenance operations on the backend.

Changes

  1. Added API call functions and services and linked them to the endpoint.
  2. Designed the functions to prepare the user request suitable for the API.

How to test

  1. Run npm start at the project's diretory.
  2. Visit /admin/mantainance.
  3. Select operations of your choice.
  4. Press submit button

Example

mtn.mp4

@dushimsam dushimsam force-pushed the dushimsam/feat/admin/maintenance-integration branch 2 times, most recently from c06b5cc to 49863dc Compare August 15, 2022 17:38
@shaheemazmalmmd
Copy link
Collaborator

@dushimsam Please fix the testcases.

@dushimsam dushimsam force-pushed the dushimsam/feat/admin/maintenance-integration branch from 49863dc to f581dd0 Compare August 26, 2022 07:52
@dushimsam
Copy link
Contributor Author

dushimsam commented Aug 26, 2022

@dushimsam Please fix the testcases.

sir , it was the problem from the already existing test-cases for getAllLicenseApi , createCandidateLicenseApi , getInfoApi
& getHealthApi which were not passing; thus interfered with my work, but i have managed to go through them again and fix the problem that was there.

@dushimsam dushimsam force-pushed the dushimsam/feat/admin/maintenance-integration branch from f581dd0 to dee71c9 Compare August 26, 2022 08:01
@shaheemazmalmmd shaheemazmalmmd added needs review Need code review needs test Needs testing labels Aug 26, 2022
@github-actions
Copy link

This pull request has conflicts, please rebase to resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the has merge conflicts PR has merge conflicts, require rebase label Aug 29, 2022
@dushimsam dushimsam force-pushed the dushimsam/feat/admin/maintenance-integration branch from dee71c9 to 5b4b8e7 Compare August 29, 2022 15:43
@github-actions github-actions bot removed the has merge conflicts PR has merge conflicts, require rebase label Aug 29, 2022
@dushimsam
Copy link
Contributor Author

This pull request has conflicts, please rebase to resolve those before we can evaluate the pull request.

resolved conflicts

@dushimsam dushimsam force-pushed the dushimsam/feat/admin/maintenance-integration branch from 5b4b8e7 to 530481f Compare August 30, 2022 03:53
@shaheemazmalmmd
Copy link
Collaborator

Tested the branch was not able to schedule the maintenance agent. Please check.
screenShot49

@dushimsam dushimsam force-pushed the dushimsam/feat/admin/maintenance-integration branch from 530481f to 1c843eb Compare September 5, 2022 11:34
@dushimsam
Copy link
Contributor Author

Tested the branch was not able to schedule the maintenance agent. Please check. screenShot49

sorry issue fixed now.

@dushimsam dushimsam force-pushed the dushimsam/feat/admin/maintenance-integration branch from 1c843eb to b0dac7a Compare September 5, 2022 11:44
@shaheemazmalmmd
Copy link
Collaborator

@dushimsam : branch is working fine. A suggestion ?

  • You can uncheck the selected checkboxes if the agent schedule is successful.
  • In case of agent/schedule failure you can keep the checkboxes checked.

@shaheemazmalmmd shaheemazmalmmd removed the needs review Need code review label Sep 5, 2022
@dushimsam
Copy link
Contributor Author

@dushimsam : branch is working fine. A suggestion ?

  • You can uncheck the selected checkboxes if the agent schedule is successful.
  • In case of agent/schedule failure you can keep the checkboxes checked.

on it sir

@dushimsam dushimsam force-pushed the dushimsam/feat/admin/maintenance-integration branch from b0dac7a to 4714044 Compare September 5, 2022 16:14
@dushimsam
Copy link
Contributor Author

dushimsam commented Sep 5, 2022

Everything working perfectly now sir , would you check again.

@shaheemazmalmmd shaheemazmalmmd merged commit cf11dae into fossology:main Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs test Needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants